dart2js: more uses of the model in the old emitter.

dart2js: more uses of the model in the old emitter.

Some renamings.

R=ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42917
Reverted: https://code.google.com/p/dart/source/detail?r=42922

Committed: https://code.google.com/p/dart/source/detail?r=42934
Reverted: https://code.google.com/p/dart/source/detail?r=42939

Committed: https://code.google.com/p/dart/source/detail?r=42995

[floitsch, 2015-01-15 15:07:25]

floitsch@google.com changed reviewers:
+ ahe@google.com

[ahe, 2015-01-15 16:25:11]

https://codereview.chromium.org/787233006/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart (left):

https://codereview.chromium.org/787233006/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart:15: * Invariant:
[classElement] must be a declaration element.
Is this no longer the case?

[ahe, 2015-01-15 16:25:19]

lgtm

[floitsch, 2015-01-15 16:27:41]

https://codereview.chromium.org/787233006/diff/1/pkg/compiler/lib/src/js_emit...
File pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart (left):

https://codereview.chromium.org/787233006/diff/1/pkg/compiler/lib/src/js_emit...
pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart:15: * Invariant:
[classElement] must be a declaration element.
On 2015/01/15 16:25:10, ahe wrote:
> Is this no longer the case?

It is, but the argument is not provided as argument anymore.
The assert is still there.
Eventually the element will not be used here anymore.

[floitsch, 2015-01-15 16:28:37]

Committed patchset #1 (id:1) manually as 42917 (presubmit successful).

[floitsch, 2015-01-15 20:15:09]

Had to revert.
Reopening.

[floitsch, 2015-01-15 20:41:35]

PTAL.
It looks like native classes are not yet in the model.
When a class is looking up its superclass in the model it would fail to find
that class and think that it doesn't have any superclass.

Temporary work-around: ask the element for the superclass.

[ahe, 2015-01-15 20:46:46]

lgtm

[floitsch, 2015-01-15 21:12:45]

Committed patchset #3 (id:40001) manually as 42934 (presubmit successful).

[floitsch, 2015-01-16 15:09:33]

Another revert :(
Uploaded another rebased CL.

[floitsch, 2015-01-16 16:58:10]

Fix is pending in another CL: https://chromiumcodereview.appspot.com/858433005/

The new code was just hitting an old bug...

Once that CL lands, I will reland this CL.

[floitsch, 2015-01-19 15:07:45]

Committed patchset #4 (id:60001) manually as 42995 (presubmit successful).