Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 78723002: Make sure variable names used in status files are available in the environment (Closed)

Created:
7 years, 1 month ago by kustermann
Modified:
7 years, 1 month ago
Reviewers:
ricow1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make sure variable names used in status files are available in the environment Previously we didn't validate that a variable name used in a status file expression was available. It wasn't surfaced, since lookups in Map objects return null if the key is missing and calling 'toString()' on 'null' doesn't throw an exception. BUG=http://dartbug.com/12959 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=30502

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M tools/testing/dart/status_expression.dart View 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
kustermann
7 years, 1 month ago (2013-11-20 16:00:46 UTC) #1
ricow1
LGTM
7 years, 1 month ago (2013-11-21 09:52:54 UTC) #2
kustermann
7 years, 1 month ago (2013-11-21 09:54:43 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30502 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698