Issue 78663004: fix script tags -- remove special case handling for polymer-element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 78663004: fix script tags -- remove special case handling for polymer-element (Closed)

Created:
7 years, 1 month ago by Jennifer Messerly

Modified:
7 years, 1 month ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Description

fix script tags -- remove special case handling for polymer-element also enforce one-dart-script-per-document rule also fixes bug about inlining all content, not just polymer-element R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=30486

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 7 years, 1 month ago

	Unified diffs	Side-by-side diffs	Stats (+83 lines, -59 lines)
M	pkg/observe/pubspec.yaml	View	1 chunk	+2 lines, -2 lines	0 comments
M	pkg/polymer/lib/src/build/import_inliner.dart	View	6 chunks	+35 lines, -50 lines	0 comments
M	pkg/polymer/pubspec.yaml	View	2 chunks	+3 lines, -3 lines	0 comments
M	pkg/polymer/test/build/import_inliner_test.dart	View	1 chunk	+37 lines, -0 lines	0 comments
M	pkg/shadow_dom/pubspec.yaml	View	1 chunk	+3 lines, -3 lines	0 comments
M	pkg/third_party/html5lib/lib/dom.dart	View	1 chunk	+2 lines, -0 lines	0 comments
M	pkg/third_party/html5lib/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

I tried to simplify the logic a little bit. It seems like http://dartbug.com/12613 can be ...

7 years, 1 month ago (2013-11-20 21:34:44 UTC) #1

Jennifer Messerly

https://codereview.chromium.org/78663004/diff/1/pkg/polymer/lib/src/build/import_inliner.dart File pkg/polymer/lib/src/build/import_inliner.dart (right): https://codereview.chromium.org/78663004/diff/1/pkg/polymer/lib/src/build/import_inliner.dart#newcode61 pkg/polymer/lib/src/build/import_inliner.dart:61: // TODO(jmesserly): technically this is more premissive than Removing ...

7 years, 1 month ago (2013-11-20 21:35:58 UTC) #2

Jennifer Messerly

7 years, 1 month ago (2013-11-20 22:13:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r30486 (presubmit successful).

Expand Messages | Collapse Messages