Issue 78573003: Remove hack for length access of typed arrays.

Issue 78573003: Remove hack for length access of typed arrays. (Closed)

Created:
7 years, 1 month ago by ngeoffray

Modified:
7 years, 1 month ago

Reviewers:
kasperl, sra1

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove hack for length access of typed arrays. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=30473

Patch Set 1 #

Total comments: 4

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -45 lines)			Patch
	M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View		1 chunk	+1 line, -24 lines	0 comments	Download
	M	sdk/lib/typed_data/dart2js/typed_data_dart2js.dart	View		10 chunks	+9 lines, -21 lines	4 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

Committed patchset #1 manually as r30473 (presubmit successful).

7 years, 1 month ago (2013-11-20 15:02:28 UTC) #3

sra1

https://codereview.chromium.org/78573003/diff/1/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart File sdk/lib/typed_data/dart2js/typed_data_dart2js.dart (right): https://codereview.chromium.org/78573003/diff/1/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart#newcode90 sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:90: // typed arrays. Remove this too? https://codereview.chromium.org/78573003/diff/1/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart#newcode525 sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:525: source._setCachedLength(); ...

7 years, 1 month ago (2013-11-20 21:07:12 UTC) #4

ngeoffray

7 years, 1 month ago (2013-11-21 07:47:33 UTC) #5

Message was sent while issue was closed.

Thanks Stephen. Done in: https://codereview.chromium.org/80393003

https://codereview.chromium.org/78573003/diff/1/sdk/lib/typed_data/dart2js/ty...
File sdk/lib/typed_data/dart2js/typed_data_dart2js.dart (right):

https://codereview.chromium.org/78573003/diff/1/sdk/lib/typed_data/dart2js/ty...
sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:90: // typed arrays.
On 2013/11/20 21:07:12, sra1 wrote:
> Remove this too?

Done.

https://codereview.chromium.org/78573003/diff/1/sdk/lib/typed_data/dart2js/ty...
sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:525:
source._setCachedLength();
On 2013/11/20 21:07:12, sra1 wrote:
> And here

Done.

Expand Messages | Collapse Messages