Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 784843002: Move isolateStaticClosureAccess and isolateLazyInitializerAccess from namer to emitter. (Closed)

Created:
6 years ago by zarah
Modified:
6 years ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Move isolateStaticClosureAccess and isolateLazyInitializerAccess from namer to emitter. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=42159

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -15 lines) Patch
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 2 chunks +10 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart View 1 chunk +10 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart View 2 chunks +11 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
zarah
6 years ago (2014-12-08 08:23:06 UTC) #2
floitsch
LGTM!
6 years ago (2014-12-08 10:06:45 UTC) #3
zarah
6 years ago (2014-12-08 11:38:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42159 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698