Adjust environments we attach to the block entries.

Adjust environments we attach to the block entries.

There were two bugs in the code:

- we did not ensure proper outer environment on block entries after inlining;

- we did not correct the 'after' environment for eager deopt

There is one bug still with the infrastructure: our deoptimization stub does *not* support eager deoptimization to the after deoptimization point.

I am leaving it like this for now, because we don't actually ever perform such deoptimization (i.e. even though we diligently attach these environments we don't actually use them in the instruction that can deopt).

R=fschneider@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=42257

[Florian Schneider, 2014-12-10 15:21:54]

LGTM.
We should try to not remove environments at block entries at all. I don't recall
the details why they are needed, but if they're broken, there is no point in
having them just to satisfy compiler-internal assertions.

https://codereview.chromium.org/784223006/diff/1/runtime/vm/flow_graph_range_...
File runtime/vm/flow_graph_range_analysis.cc (right):

https://codereview.chromium.org/784223006/diff/1/runtime/vm/flow_graph_range_...
runtime/vm/flow_graph_range_analysis.cc:1: 
Remove \n.

[Vyacheslav Egorov (Google), 2014-12-10 18:32:28]

Committed patchset #1 (id:1) manually as 42257 (presubmit successful).