Issue 78393005: More cleanup in the socket C++ code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 78393005: More cleanup in the socket C++ code (Closed)

Created:
7 years ago by Søren Gjesse

Modified:
7 years ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

More cleanup in the socket C++ code R=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=30564

Patch Set 2 : Addressed review comments #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -33 lines)			Patch
	M	runtime/bin/socket.cc	View	1	5 chunks	+16 lines, -33 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM! https://codereview.chromium.org/78393005/diff/1/runtime/bin/socket.cc File runtime/bin/socket.cc (right): https://codereview.chromium.org/78393005/diff/1/runtime/bin/socket.cc#newcode36 runtime/bin/socket.cc:36: printf("XXXXXXXXXXXXXXXXXX\n"); Debug print. https://codereview.chromium.org/78393005/diff/1/runtime/bin/socket.cc#newcode37 runtime/bin/socket.cc:37: Dart_TypedDataReleaseData(obj); Why do ...

7 years ago (2013-11-22 06:43:41 UTC) #2

Søren Gjesse

https://codereview.chromium.org/78393005/diff/1/runtime/bin/socket.cc File runtime/bin/socket.cc (right): https://codereview.chromium.org/78393005/diff/1/runtime/bin/socket.cc#newcode36 runtime/bin/socket.cc:36: printf("XXXXXXXXXXXXXXXXXX\n"); On 2013/11/22 06:43:41, Anders Johnsen wrote: > Debug ...

7 years ago (2013-11-22 07:18:52 UTC) #3

Søren Gjesse

7 years ago (2013-11-22 08:02:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r30564 (presubmit successful).

Expand Messages | Collapse Messages

Issue 78393005: More cleanup in the socket C++ code (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed review comments #

Messages