Issue 783683002: Better constant folding of length-loads in checked mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 783683002: Better constant folding of length-loads in checked mode. (Closed)

Created:
6 years ago by Florian Schneider

Modified:
6 years ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Better constant folding of length-loads in checked mode. Handle redefinitions (Redefinition/AssertAssignable) when checking for known constant length. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=42132

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -7 lines)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View	1	2 chunks	+6 lines, -4 lines	0 comments	Download
	M	runtime/vm/intermediate_language.cc	View		3 chunks	+6 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Vyacheslav Egorov (Google)

lgtm https://codereview.chromium.org/783683002/diff/1/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (left): https://codereview.chromium.org/783683002/diff/1/runtime/vm/flow_graph_optimizer.cc#oldcode8245 runtime/vm/flow_graph_optimizer.cc:8245: if (num_elements->BindsToConstant() && Maybe BindsToConstant/BoundConstant should also be ...

6 years ago (2014-12-05 13:45:16 UTC) #3

Florian Schneider

6 years ago (2014-12-05 14:02:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r42132 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages