Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 783393005: fix logic for detecting when in an auto-binding element (Closed)

Created:
6 years ago by jakemac
Modified:
6 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

fix logic for detecting when in an auto-binding element R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=42254

Patch Set 1 #

Patch Set 2 : update changelog/pubspec #

Total comments: 2

Patch Set 3 : reword #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M pkg/polymer/CHANGELOG.md View 1 2 3 1 chunk +5 lines, -1 line 0 comments Download
M pkg/polymer/lib/src/build/linter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/polymer/pubspec.yaml View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/build/linter_test.dart View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
jakemac
6 years ago (2014-12-09 19:16:53 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/783393005/diff/20001/pkg/polymer/CHANGELOG.md File pkg/polymer/CHANGELOG.md (right): https://codereview.chromium.org/783393005/diff/20001/pkg/polymer/CHANGELOG.md#newcode2 pkg/polymer/CHANGELOG.md:2: * Fix logic for detecting when in an ...
6 years ago (2014-12-09 20:56:24 UTC) #3
jakemac
https://codereview.chromium.org/783393005/diff/20001/pkg/polymer/CHANGELOG.md File pkg/polymer/CHANGELOG.md (right): https://codereview.chromium.org/783393005/diff/20001/pkg/polymer/CHANGELOG.md#newcode2 pkg/polymer/CHANGELOG.md:2: * Fix logic for detecting when in an `auto-binding-dart` ...
6 years ago (2014-12-09 22:26:21 UTC) #4
jakemac
6 years ago (2014-12-10 18:06:13 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as 42254 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698