Issue 781643002: Removing unnecessary warning when parsing Json.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 781643002: Removing unnecessary warning when parsing Json. (Closed)

Created:
6 years ago by tjblasi

Modified:
6 years ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org, Chris Bracken

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Removing unnecessary warning when parsing Json. BUG= R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=42098

Patch Set 1 #

Total comments: 1

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+7 lines, -5 lines)			Patch
M	pkg/source_maps/CHANGELOG.md	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	pkg/source_maps/lib/parser.dart	View	1 chunk	+0 lines, -4 lines	1 comment	Download
M	pkg/source_maps/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Siggi Cherem (dart-lang)

lgtm https://codereview.chromium.org/781643002/diff/1/pkg/source_maps/lib/parser.dart File pkg/source_maps/lib/parser.dart (left): https://codereview.chromium.org/781643002/diff/1/pkg/source_maps/lib/parser.dart#oldcode34 pkg/source_maps/lib/parser.dart:34: if (!map.containsKey('file')) { oh cool - it seems ...

6 years ago (2014-12-04 00:12:23 UTC) #3

tjblasi

6 years ago (2014-12-04 01:16:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42098 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages