Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Issue 781333003: Start running new completion tests. (Closed)

Created:
6 years ago by Paul Berry
Modified:
6 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -156 lines) Patch
M pkg/analysis_server/test/completion_test.dart View 82 chunks +248 lines, -151 lines 1 comment Download
M pkg/analysis_server/test/completion_test_support.dart View 4 chunks +34 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
Several pieces of functionality still need to be implemented: - Negative tests don't yet work ...
6 years ago (2014-12-08 22:59:57 UTC) #2
danrubel
lgtm
6 years ago (2014-12-08 23:17:06 UTC) #3
Brian Wilkerson
LGTM https://codereview.chromium.org/781333003/diff/1/pkg/analysis_server/test/completion_test.dart File pkg/analysis_server/test/completion_test.dart (right): https://codereview.chromium.org/781333003/diff/1/pkg/analysis_server/test/completion_test.dart#newcode2137 pkg/analysis_server/test/completion_test.dart:2137: // exiting, for some unknown reason. TODO(paulberry): fix ...
6 years ago (2014-12-09 00:12:28 UTC) #4
Paul Berry
6 years ago (2014-12-09 16:44:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42210 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698