Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 781223002: Simplify dart2js StringBuffer constructor to be initializer-only. (Closed)

Created:
6 years ago by sra1
Modified:
6 years ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Simplify dart2js StringBuffer constructor to be initializer-only. The constructor is now small enough to always inline and the interpolation is usually constant-folded from the default argument, leading to the elimination of the silly looking store: t1 = new P.StringBuffer(""); t1._contents = ""; --> t1 = new P.StringBuffer(""); R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=42212

Patch Set 1 #

Patch Set 2 : add type to flattenString to improve type inference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M sdk/lib/_internal/compiler/js_lib/core_patch.dart View 1 chunk +2 lines, -8 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_helper.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
sra1
6 years ago (2014-12-06 01:48:22 UTC) #2
sra1
ping
6 years ago (2014-12-09 04:05:45 UTC) #3
floitsch
LGTM.
6 years ago (2014-12-09 10:05:59 UTC) #4
sra1
6 years ago (2014-12-09 17:51:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42212 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698