Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 780643002: More work on logging - new classes and timers. (Closed)

Created:
6 years ago by scheglov
Modified:
6 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

More work on logging - new classes and timers. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42090

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -39 lines) Patch
M pkg/analysis_server/lib/driver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_logger.dart View 4 chunks +93 lines, -10 lines 2 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 13 chunks +54 lines, -28 lines 2 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years ago (2014-12-03 19:20:38 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/780643002/diff/1/pkg/analyzer/lib/src/generated/incremental_logger.dart File pkg/analyzer/lib/src/generated/incremental_logger.dart (right): https://codereview.chromium.org/780643002/diff/1/pkg/analyzer/lib/src/generated/incremental_logger.dart#newcode54 pkg/analyzer/lib/src/generated/incremental_logger.dart:54: class LoggerTimer { nit: Perhaps "LoggingTimer"? https://codereview.chromium.org/780643002/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart File ...
6 years ago (2014-12-03 19:31:12 UTC) #2
scheglov
https://codereview.chromium.org/780643002/diff/1/pkg/analyzer/lib/src/generated/incremental_logger.dart File pkg/analyzer/lib/src/generated/incremental_logger.dart (right): https://codereview.chromium.org/780643002/diff/1/pkg/analyzer/lib/src/generated/incremental_logger.dart#newcode54 pkg/analyzer/lib/src/generated/incremental_logger.dart:54: class LoggerTimer { On 2014/12/03 19:31:12, Brian Wilkerson wrote: ...
6 years ago (2014-12-03 19:46:35 UTC) #3
scheglov
6 years ago (2014-12-03 19:47:13 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 42090 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698