Issue 78043002: Fix timezone extraction for IE and Opera.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 78043002: Fix timezone extraction for IE and Opera. (Closed)

Created:
7 years, 1 month ago by floitsch

Modified:
7 years, 1 month ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix timezone extraction for IE and Opera. Not perfect, but these browsers don't give enough information. BUG= http://dartbug.com/14717 BUG= http://dartbug.com/14691 BUG= http://dartbug.com/15027 R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=30469

Patch Set 2 : Remove duplicated comment. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -22 lines)			Patch
	M	sdk/lib/_internal/lib/js_helper.dart	View	1	1 chunk	+28 lines, -20 lines	0 comments	Download
	M	tests/corelib/corelib.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

lgtm https://codereview.chromium.org/78043002/diff/1/sdk/lib/_internal/lib/js_helper.dart File sdk/lib/_internal/lib/js_helper.dart (right): https://codereview.chromium.org/78043002/diff/1/sdk/lib/_internal/lib/js_helper.dart#newcode530 sdk/lib/_internal/lib/js_helper.dart:530: // Internet Explorer 10+ doesn't put the zone ...

7 years, 1 month ago (2013-11-20 12:55:33 UTC) #2

floitsch

https://codereview.chromium.org/78043002/diff/1/sdk/lib/_internal/lib/js_helper.dart File sdk/lib/_internal/lib/js_helper.dart (right): https://codereview.chromium.org/78043002/diff/1/sdk/lib/_internal/lib/js_helper.dart#newcode530 sdk/lib/_internal/lib/js_helper.dart:530: // Internet Explorer 10+ doesn't put the zone name ...

7 years, 1 month ago (2013-11-20 13:57:27 UTC) #3

floitsch

7 years, 1 month ago (2013-11-20 13:58:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r30469 (presubmit successful).

Expand Messages | Collapse Messages

Issue 78043002: Fix timezone extraction for IE and Opera. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Remove duplicated comment. #

Messages