Improve debugger in MIPS simulator.

Improve debugger in MIPS simulator.
Validate integer flag values and allow hex flag values.

R=zra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42139

[regis, 2014-12-05 00:42:28]

regis@google.com changed reviewers:
+ zra@google.com

[regis, 2014-12-05 00:42:28]

I needed this to figure out the gc bug on MIPS.

Similarly improving both ARM simulators is now on my TODO list.

Thanks

[zra, 2014-12-05 17:41:03]

lgtm

https://codereview.chromium.org/780173002/diff/1/runtime/vm/simulator_mips.cc
File runtime/vm/simulator_mips.cc (right):

https://codereview.chromium.org/780173002/diff/1/runtime/vm/simulator_mips.cc...
runtime/vm/simulator_mips.cc:2307: } else if (reinterpret_cast<int>(instr) ==
FLAG_stop_sim_at) {
Is this useful? Won't the address you want be different on the next run?

[regis, 2014-12-05 18:36:33]

On 2014/12/05 17:41:03, zra wrote:
> lgtm
> 
> https://codereview.chromium.org/780173002/diff/1/runtime/vm/simulator_mips.cc
> File runtime/vm/simulator_mips.cc (right):
> 
>
https://codereview.chromium.org/780173002/diff/1/runtime/vm/simulator_mips.cc...
> runtime/vm/simulator_mips.cc:2307: } else if (reinterpret_cast<int>(instr) ==
> FLAG_stop_sim_at) {
> Is this useful? Won't the address you want be different on the next run?

As discussed, it may still be useful when running under gdb.

Thanks!

[regis, 2014-12-05 18:37:16]

Committed patchset #1 (id:1) manually as r42139 (presubmit successful).