Add substitutions even when type arguments are fixed.

Add substitutions even when type arguments are fixed.

BUG=http://dartbug.com/14145
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31333

[karlklose, 2013-11-20 10:25:25]

https://codereview.chromium.org/77993002/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart
(right):

https://codereview.chromium.org/77993002/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/js_emitter/type_test_emitter.dart:138:
while (superclass != null) {
You are running through the super-chain twice now. Can't you merge this code
with the loop below?

Furthermore, we now unconditionally emit this substitution. Can't we calculate
the need for it from the usage of type variables? Perhaps we should split needs
Rti into predicates needsSubstitution and needsSubtypeTags.

[Johnni Winther, 2013-12-19 14:50:06]

PTAL

[karlklose, 2013-12-20 10:38:08]

LGTM.

https://codereview.chromium.org/77993002/diff/80001/tests/language/fixed_type...
File tests/language/fixed_type_variable_test.dart (right):

https://codereview.chromium.org/77993002/diff/80001/tests/language/fixed_type...
tests/language/fixed_type_variable_test.dart:35: testA(); /// 01: ok
Two spaces.

[Johnni Winther, 2013-12-20 12:30:31]

Committed patchset #3 manually as r31333 (presubmit successful).