Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 77983002: Only read from interrupt_fd when data is available. (Closed)

Created:
7 years, 1 month ago by Anders Johnsen
Modified:
7 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Only read from interrupt_fd when data is available. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=30453

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -75 lines) Patch
M runtime/bin/eventhandler_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/eventhandler_android.cc View 3 chunks +16 lines, -23 lines 2 comments Download
M runtime/bin/eventhandler_linux.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/eventhandler_linux.cc View 3 chunks +16 lines, -26 lines 0 comments Download
M runtime/bin/eventhandler_macos.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/bin/eventhandler_macos.cc View 4 chunks +16 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 1 month ago (2013-11-20 09:36:36 UTC) #1
Søren Gjesse
lgtm https://codereview.chromium.org/77983002/diff/1/runtime/bin/eventhandler_android.cc File runtime/bin/eventhandler_android.cc (right): https://codereview.chromium.org/77983002/diff/1/runtime/bin/eventhandler_android.cc#newcode186 runtime/bin/eventhandler_android.cc:186: kInterruptMessageSize)); We could even consider reading more than ...
7 years, 1 month ago (2013-11-20 09:46:09 UTC) #2
Anders Johnsen
https://codereview.chromium.org/77983002/diff/1/runtime/bin/eventhandler_android.cc File runtime/bin/eventhandler_android.cc (right): https://codereview.chromium.org/77983002/diff/1/runtime/bin/eventhandler_android.cc#newcode186 runtime/bin/eventhandler_android.cc:186: kInterruptMessageSize)); On 2013/11/20 09:46:09, Søren Gjesse wrote: > We ...
7 years, 1 month ago (2013-11-20 10:26:39 UTC) #3
Anders Johnsen
7 years, 1 month ago (2013-11-20 10:27:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r30453 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698