Issue 779253003: Implement correct semantics of Boolean Conversion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 779253003: Implement correct semantics of Boolean Conversion (Closed)

Created:
6 years ago by hausner

Modified:
6 years ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement correct semantics of Boolean Conversion When converting null to a boolean value, throw an AssertionError rather than a TypeError. This is the same change as r42145, with added co19 status updates. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=42170

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+175 lines, -47 lines)			Patch
M	runtime/lib/errors_patch.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View		2 chunks	+20 lines, -2 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View		6 chunks	+6 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View		3 chunks	+14 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View		3 chunks	+14 lines, -5 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View		4 chunks	+15 lines, -6 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View		3 chunks	+11 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View		3 chunks	+14 lines, -5 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download
A	tests/language/bool_check_test.dart	View	1	1 chunk	+54 lines, -0 lines	0 comments	Download
M	tests/language/vm/type_vm_test.dart	View		10 chunks	+14 lines, -16 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

hausner

6 years ago (2014-12-08 18:51:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as r42170 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages