Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 779103003: Fix bugs in heapmap, binary payloads, 'address' request. (Closed)

Created:
6 years ago by koda
Modified:
6 years ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix bugs in heapmap, binary payloads, 'address' request. - Remove forbidden extra slash. - Update binary payload parsing after type changes. - 'address' should return a full object, not a ref. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=42169

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Total comments: 2

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M runtime/bin/vmservice/observatory/lib/service_html.dart View 1 2 1 chunk +6 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M runtime/bin/vmservice/observatory/test/graph_test.dart View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M runtime/vm/service.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
koda
6 years ago (2014-12-05 23:58:20 UTC) #2
Cutch
https://codereview.chromium.org/779103003/diff/60001/runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart File runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart (right): https://codereview.chromium.org/779103003/diff/60001/runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart#newcode158 runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart:158: window.location.hash = "${fragmentation.isolate.link}/address/$address"; You shouldn't be touching the window.location.hash ...
6 years ago (2014-12-08 18:24:47 UTC) #3
koda
PTAL https://codereview.chromium.org/779103003/diff/60001/runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart File runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart (right): https://codereview.chromium.org/779103003/diff/60001/runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart#newcode158 runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart:158: window.location.hash = "${fragmentation.isolate.link}/address/$address"; On 2014/12/08 18:24:47, Cutch wrote: ...
6 years ago (2014-12-08 18:36:57 UTC) #4
Cutch
lgtm after last change to link construction https://codereview.chromium.org/779103003/diff/70001/runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart File runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart (right): https://codereview.chromium.org/779103003/diff/70001/runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart#newcode159 runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart:159: "${fragmentation.isolate.link}/address/$address")); "${fragmentation.isolate.relativeLink('/address/$address')}"
6 years ago (2014-12-08 18:40:01 UTC) #5
koda
https://codereview.chromium.org/779103003/diff/70001/runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart File runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart (right): https://codereview.chromium.org/779103003/diff/70001/runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart#newcode159 runtime/bin/vmservice/observatory/lib/src/elements/heap_map.dart:159: "${fragmentation.isolate.link}/address/$address")); On 2014/12/08 18:40:01, Cutch wrote: > "${fragmentation.isolate.relativeLink('/address/$address')}" Done.
6 years ago (2014-12-08 18:45:01 UTC) #6
koda
6 years ago (2014-12-08 18:46:05 UTC) #7
Message was sent while issue was closed. 
Committed patchset #6 (id:90001) manually as r42169 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698