Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 778983002: - Implement hashCode and == for Capability. (Closed)

Created:
6 years ago by Ivan Posva
Modified:
6 years ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

- Implement hashCode and == for Capability. R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=42102

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M runtime/lib/isolate.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M runtime/lib/isolate_patch.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/vm/bootstrap_natives.h View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/isolate/isolate.status View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Ivan Posva
6 years ago (2014-12-04 11:57:14 UTC) #2
Lasse Reichstein Nielsen
lgtm
6 years ago (2014-12-04 12:09:00 UTC) #3
Lasse Reichstein Nielsen
Might need to change isolate.status to expect capability_test to succeed.
6 years ago (2014-12-04 12:09:25 UTC) #4
Ivan Posva
6 years ago (2014-12-04 12:17:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r42102 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698