Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 778923004: mark public package dependencies test as failing since web_components isn 't yet published (Closed)

Created:
6 years ago by jakemac
Modified:
6 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

mark public package dependencies test as failing since web_components isn 't yet published R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=42118

Patch Set 1 #

Patch Set 2 : also fix references to platform.js #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M pkg/pkgbuild.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/html/custom/attribute_changed_callback_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/html/custom/constructor_calls_created_synchronously_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/html/custom/created_callback_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/html/custom/document_register_basic_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/html/custom/document_register_type_extensions_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/html/custom/element_upgrade_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/html/custom/entered_left_view_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/html/custom/js_custom_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/html/custom/mirrors_test.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/html/custom_elements_test.html View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jakemac
6 years ago (2014-12-04 20:07:11 UTC) #3
jakemac
6 years ago (2014-12-04 20:07:11 UTC) #4
Siggi Cherem (dart-lang)
lgtm
6 years ago (2014-12-04 20:23:32 UTC) #5
jakemac
6 years ago (2014-12-04 21:24:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42118 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698