Issue 778153003: Consider adding/editing a method as a resolvable mismatch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 778153003: Consider adding/editing a method as a resolvable mismatch. (Closed)

Created:
6 years ago by scheglov

Modified:
6 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Consider adding/editing a method as a resolvable mismatch. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42142

Patch Set 1 #

Total comments: 2

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+295 lines, -193 lines)			Patch
	M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View		8 chunks	+92 lines, -26 lines	0 comments	Download
	M	pkg/analyzer/test/generated/incremental_resolver_test.dart	View		166 chunks	+203 lines, -167 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/778153003/diff/1/pkg/analyzer/test/generated/incremental_resolver_test.dart File pkg/analyzer/test/generated/incremental_resolver_test.dart (right): https://codereview.chromium.org/778153003/diff/1/pkg/analyzer/test/generated/incremental_resolver_test.dart#newcode1863 pkg/analyzer/test/generated/incremental_resolver_test.dart:1863: void _assertCompilationUnitMatchesFalse(String oldContent, Consider "_assertCompilationUnitDoesNotMatch". https://codereview.chromium.org/778153003/diff/1/pkg/analyzer/test/generated/incremental_resolver_test.dart#newcode1871 pkg/analyzer/test/generated/incremental_resolver_test.dart:1871: void ...

6 years ago (2014-12-05 19:38:05 UTC) #2

scheglov

6 years ago (2014-12-05 19:46:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42142 (presubmit successful).

Expand Messages | Collapse Messages