Implement correct semantics of Boolean Conversion

Implement correct semantics of Boolean Conversion

When converting null to a boolean value, throw an AssertionError
rather than a TypeError.

Fixes issue 21279.

R=srdjan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42145

[hausner, 2014-12-05 00:38:01]

hausner@google.com changed reviewers:
+ srdjan@google.com

[srdjan, 2014-12-05 00:49:28]

lgtm

https://codereview.chromium.org/778063002/diff/20001/runtime/vm/code_generato...
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/778063002/diff/20001/runtime/vm/code_generato...
runtime/vm/code_generator.cc:58: DECLARE_FLAG(bool, enable_asserts);
Please order alphabetically.

https://codereview.chromium.org/778063002/diff/20001/runtime/vm/code_generato...
runtime/vm/code_generator.cc:574: String::New("Failed assertion: boolean
expression must not be null")));
s/boolean/Boolean/

https://codereview.chromium.org/778063002/diff/20001/runtime/vm/flow_graph_bu...
File runtime/vm/flow_graph_builder.cc (right):

https://codereview.chromium.org/778063002/diff/20001/runtime/vm/flow_graph_bu...
runtime/vm/flow_graph_builder.cc:42: DECLARE_FLAG(bool, enable_asserts);
alphabetically.

https://codereview.chromium.org/778063002/diff/20001/runtime/vm/intermediate_...
File runtime/vm/intermediate_language_x64.cc (right):

https://codereview.chromium.org/778063002/diff/20001/runtime/vm/intermediate_...
runtime/vm/intermediate_language_x64.cc:26: DECLARE_FLAG(bool, enable_asserts);
please sort alphabetically (also in other architectures)

[hausner, 2014-12-05 20:36:10]

https://codereview.chromium.org/778063002/diff/20001/runtime/vm/code_generato...
File runtime/vm/code_generator.cc (right):

https://codereview.chromium.org/778063002/diff/20001/runtime/vm/code_generato...
runtime/vm/code_generator.cc:58: DECLARE_FLAG(bool, enable_asserts);
On 2014/12/05 00:49:28, srdjan wrote:
> Please order alphabetically.

Done.

https://codereview.chromium.org/778063002/diff/20001/runtime/vm/code_generato...
runtime/vm/code_generator.cc:574: String::New("Failed assertion: boolean
expression must not be null")));
On 2014/12/05 00:49:28, srdjan wrote:
> s/boolean/Boolean/

We always start error messages with lower case.

https://codereview.chromium.org/778063002/diff/20001/runtime/vm/flow_graph_bu...
File runtime/vm/flow_graph_builder.cc (right):

https://codereview.chromium.org/778063002/diff/20001/runtime/vm/flow_graph_bu...
runtime/vm/flow_graph_builder.cc:42: DECLARE_FLAG(bool, enable_asserts);
On 2014/12/05 00:49:28, srdjan wrote:
> alphabetically.

Done.

https://codereview.chromium.org/778063002/diff/20001/runtime/vm/intermediate_...
File runtime/vm/intermediate_language_x64.cc (right):

https://codereview.chromium.org/778063002/diff/20001/runtime/vm/intermediate_...
runtime/vm/intermediate_language_x64.cc:26: DECLARE_FLAG(bool, enable_asserts);
On 2014/12/05 00:49:28, srdjan wrote:
> please sort alphabetically (also in other architectures)

They are already in alphabetical order.

[hausner, 2014-12-05 20:36:45]

Committed patchset #3 (id:40001) manually as r42145 (presubmit successful).