Issue 774983003: Add logging to the incremental resolver.

Issue 774983003: Add logging to the incremental resolver. (Closed)

Created:
6 years ago by scheglov

Modified:
6 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add logging to the incremental resolver. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42087

Patch Set 2 : Extract logger into a separate library. Remove dart:io dependency. #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+187 lines, -15 lines)			Patch
M	editor/tools/plugins/com.google.dart.tools.core/.options	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/DartCore.java	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/DartCoreDebug.java	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/analysis_server/lib/driver.dart	View	1	5 chunks	+39 lines, -2 lines	0 comments	Download
A	pkg/analyzer/lib/src/generated/incremental_logger.dart	View	1	1 chunk	+113 lines, -0 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View	1	8 chunks	+25 lines, -13 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

https://codereview.chromium.org/774983003/diff/1/pkg/analysis_server/lib/driver.dart File pkg/analysis_server/lib/driver.dart (right): https://codereview.chromium.org/774983003/diff/1/pkg/analysis_server/lib/driver.dart#newcode111 pkg/analysis_server/lib/driver.dart:111: help: "the description of the incremental resolition log"); "resolition" ...

6 years ago (2014-12-03 15:05:17 UTC) #2

scheglov

PTAL https://codereview.chromium.org/774983003/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right): https://codereview.chromium.org/774983003/diff/1/pkg/analyzer/lib/src/generated/incremental_resolver.dart#newcode24 pkg/analyzer/lib/src/generated/incremental_resolver.dart:24: _Logger _logger = new _NullLogger(); On 2014/12/03 15:05:17, ...

6 years ago (2014-12-03 15:58:10 UTC) #3

scheglov

6 years ago (2014-12-03 18:04:45 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 42087 (presubmit successful).

Expand Messages | Collapse Messages