Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 774213002: Bugfix in ListProperty(), correctly handle list values of length 1 (Closed)

Created:
6 years ago by kustermann
Modified:
6 years ago
Reviewers:
wibling, Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/gcloud.git@master
Visibility:
Public.

Description

[datastore] Bugfix in ListProperty(), correctly handle list values of length 1 BUG=https://github.com/dart-lang/gcloud/issues/17 R=sgjesse@google.com Committed: https://github.com/dart-lang/gcloud/commit/a89fd6a81b500f13a0334cc9098423cf0cffc96a

Patch Set 1 #

Patch Set 2 : Added entry in CHANGELOG.md #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -2 lines) Patch
M CHANGELOG.md View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/src/db/annotations.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M test/db/properties_test.dart View 3 chunks +53 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kustermann
6 years ago (2014-12-03 14:51:26 UTC) #2
kustermann
6 years ago (2014-12-03 14:51:35 UTC) #3
Søren Gjesse
lgtm
6 years ago (2014-12-03 15:19:57 UTC) #4
kustermann
6 years ago (2014-12-03 15:38:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
a89fd6a81b500f13a0334cc9098423cf0cffc96a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698