Issue 77413004: Pushes 0 for PC marker in runtime call stubs on ARM and MIPS.

Issue 77413004: Pushes 0 for PC marker in runtime call stubs on ARM and MIPS. (Closed)

Created:
7 years, 1 month ago by zra

Modified:
7 years, 1 month ago

Reviewers:
regis, Kevin Millikin (Google), siva, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Pushes 0 for PC marker in runtime call stubs on ARM and MIPS. R=iposva@google.com, regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=30555

Patch Set 4 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -19 lines)			Patch
	pkg/pkg.status	View	1 2 3	1 chunk	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/code_generator.cc	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/stack_frame.cc	View	1 2 3	1 chunk	+6 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View	1 2 3	8 chunks	+15 lines, -3 lines	0 comments	Download
M	runtime/vm/stub_code_mips.cc	View	1 2 3	9 chunks	+34 lines, -11 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/77413004/diff/100001/runtime/vm/stub_code_arm.cc File runtime/vm/stub_code_arm.cc (right): https://codereview.chromium.org/77413004/diff/100001/runtime/vm/stub_code_arm.cc#newcode103 runtime/vm/stub_code_arm.cc:103: // Adjust SP for the null PC ...

7 years, 1 month ago (2013-11-21 23:14:55 UTC) #4

zra

https://codereview.chromium.org/77413004/diff/100001/runtime/vm/stub_code_arm.cc File runtime/vm/stub_code_arm.cc (right): https://codereview.chromium.org/77413004/diff/100001/runtime/vm/stub_code_arm.cc#newcode103 runtime/vm/stub_code_arm.cc:103: // Adjust SP for the null PC marker. On ...

7 years, 1 month ago (2013-11-21 23:18:41 UTC) #5

zra

7 years, 1 month ago (2013-11-21 23:18:58 UTC) #6

Message was sent while issue was closed.

Committed patchset #4 manually as r30555 (presubmit successful).

Expand Messages | Collapse Messages