Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 77373002: "Reverting 30388" (Closed)

Created:
7 years, 1 month ago by Jennifer Messerly
Modified:
7 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

"Reverting 30388" This is a new TodoMVC based on Polymer's version, now fixed on IE. Also fixes two other bugs in how we were handling styles: * scoped styles were broken unless browser supported them natively * link rel=stylesheet for external styles was broken (restore) https://code.google.com/p/dart/source/detail?r=30387 (revert) https://code.google.com/p/dart/source/detail?r=30388 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=30554

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1372 lines, -1048 lines) Patch
M pkg/polymer/lib/src/build/linter.dart View 3 chunks +1 line, -19 lines 0 comments Download
M pkg/polymer/lib/src/declaration.dart View 1 4 chunks +35 lines, -8 lines 1 comment Download
M pkg/polymer/test/build/linter_test.dart View 6 chunks +7 lines, -15 lines 0 comments Download
A samples/third_party/todomvc/AUTHORS View 1 chunk +9 lines, -0 lines 0 comments Download
M samples/third_party/todomvc/LICENSE View 1 chunk +27 lines, -10 lines 0 comments Download
A samples/third_party/todomvc/PATENTS View 1 chunk +23 lines, -0 lines 0 comments Download
M samples/third_party/todomvc/README.md View 1 chunk +32 lines, -14 lines 0 comments Download
M samples/third_party/todomvc/pubspec.yaml View 1 2 1 chunk +1 line, -1 line 0 comments Download
M samples/third_party/todomvc/test/listorder_test.dart View 3 chunks +13 lines, -8 lines 0 comments Download
M samples/third_party/todomvc/test/listorder_test.html View 2 chunks +7 lines, -5 lines 0 comments Download
M samples/third_party/todomvc/test/mainpage_test.dart View 1 2 2 chunks +31 lines, -15 lines 0 comments Download
M samples/third_party/todomvc/test/mainpage_test.html View 2 chunks +7 lines, -5 lines 0 comments Download
M samples/third_party/todomvc/test/markdone_shadow_test.html View 2 chunks +7 lines, -5 lines 0 comments Download
M samples/third_party/todomvc/test/markdone_test.dart View 4 chunks +15 lines, -24 lines 0 comments Download
M samples/third_party/todomvc/test/markdone_test.html View 2 chunks +7 lines, -5 lines 0 comments Download
A samples/third_party/todomvc/test/utils.dart View 1 chunk +23 lines, -0 lines 0 comments Download
D samples/third_party/todomvc/web/app.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D samples/third_party/todomvc/web/app.html View 1 chunk +0 lines, -57 lines 0 comments Download
A samples/third_party/todomvc/web/app/app.css View 1 chunk +206 lines, -0 lines 0 comments Download
A + samples/third_party/todomvc/web/app/bg.png View Binary file 0 comments Download
D samples/third_party/todomvc/web/base.css View 1 chunk +0 lines, -329 lines 0 comments Download
D samples/third_party/todomvc/web/bg.png View Binary file 0 comments Download
D samples/third_party/todomvc/web/editable_label.dart View 1 chunk +0 lines, -62 lines 0 comments Download
D samples/third_party/todomvc/web/editable_label.html View 1 chunk +0 lines, -19 lines 0 comments Download
A samples/third_party/todomvc/web/elements/td_input.dart View 1 1 chunk +27 lines, -0 lines 0 comments Download
A samples/third_party/todomvc/web/elements/td_input.html View 1 chunk +4 lines, -0 lines 0 comments Download
A samples/third_party/todomvc/web/elements/td_item.css View 1 chunk +161 lines, -0 lines 0 comments Download
A samples/third_party/todomvc/web/elements/td_item.dart View 1 chunk +45 lines, -0 lines 0 comments Download
A samples/third_party/todomvc/web/elements/td_item.html View 1 chunk +17 lines, -0 lines 0 comments Download
A samples/third_party/todomvc/web/elements/td_model.dart View 1 chunk +101 lines, -0 lines 0 comments Download
A samples/third_party/todomvc/web/elements/td_model.html View 1 chunk +3 lines, -0 lines 0 comments Download
A + samples/third_party/todomvc/web/elements/td_todos.css View 10 chunks +44 lines, -106 lines 0 comments Download
A samples/third_party/todomvc/web/elements/td_todos.dart View 1 1 chunk +60 lines, -0 lines 0 comments Download
A samples/third_party/todomvc/web/elements/td_todos.html View 1 1 chunk +51 lines, -0 lines 0 comments Download
M samples/third_party/todomvc/web/index.html View 1 chunk +27 lines, -18 lines 0 comments Download
A samples/third_party/todomvc/web/lib-elements/polymer_localstorage.dart View 1 chunk +39 lines, -0 lines 0 comments Download
A samples/third_party/todomvc/web/lib-elements/polymer_localstorage.html View 1 chunk +27 lines, -0 lines 0 comments Download
A samples/third_party/todomvc/web/lib-elements/polymer_selection.dart View 1 chunk +66 lines, -0 lines 0 comments Download
A samples/third_party/todomvc/web/lib-elements/polymer_selection.html View 1 chunk +17 lines, -0 lines 0 comments Download
A samples/third_party/todomvc/web/lib-elements/polymer_selector.dart View 1 chunk +138 lines, -0 lines 0 comments Download
A samples/third_party/todomvc/web/lib-elements/polymer_selector.html View 1 chunk +47 lines, -0 lines 0 comments Download
A samples/third_party/todomvc/web/lib-elements/simple_router.dart View 1 chunk +39 lines, -0 lines 0 comments Download
A samples/third_party/todomvc/web/lib-elements/simple_router.html View 1 chunk +8 lines, -0 lines 0 comments Download
D samples/third_party/todomvc/web/model.dart View 1 chunk +0 lines, -69 lines 0 comments Download
D samples/third_party/todomvc/web/router_options.dart View 1 chunk +0 lines, -54 lines 0 comments Download
D samples/third_party/todomvc/web/router_options.html View 1 chunk +0 lines, -9 lines 0 comments Download
D samples/third_party/todomvc/web/todo_row.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D samples/third_party/todomvc/web/todo_row.html View 1 chunk +0 lines, -127 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
Please take a look. I uploaded the already-reviewed changes in patch set 1, patch set ...
7 years, 1 month ago (2013-11-20 22:53:44 UTC) #1
Siggi Cherem (dart-lang)
lgtm! https://codereview.chromium.org/77373002/diff/160001/pkg/polymer/lib/src/declaration.dart File pkg/polymer/lib/src/declaration.dart (right): https://codereview.chromium.org/77373002/diff/160001/pkg/polymer/lib/src/declaration.dart#newcode557 pkg/polymer/lib/src/declaration.dart:557: if (!js.context.hasProperty('ShadowDOMPolyfill')) return; ! o u c h
7 years, 1 month ago (2013-11-21 01:46:13 UTC) #2
Jennifer Messerly
7 years, 1 month ago (2013-11-21 23:11:16 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r30554 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698