observatory: populate 'architecture' in VM, and add numerical vmId in Class.

observatory: populate 'architecture' in VM, and add numerical vmId in Class.

Knowing the word size and having an efficient (non-String) representation for class ids is important for the upcoming heap serialization features.

R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42115

[Cutch, 2014-12-04 16:07:22]

https://codereview.chromium.org/773303003/diff/1/runtime/bin/vmservice/observ...
File runtime/bin/vmservice/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/773303003/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/service/object.dart:561: architecture
= map['targetCPU'];
Why not rename 'architecture' to be targetCPU?

https://codereview.chromium.org/773303003/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/service/object.dart:562:
architectureBits = architecture.contains('64') ? 64 : 32;
Can we ensure this will always be correct? Why not send over explicit info from
the VM?

https://codereview.chromium.org/773303003/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/service/object.dart:1443: @observable
int vmId;
vmCid?

[koda, 2014-12-04 17:30:14]

https://codereview.chromium.org/773303003/diff/1/runtime/bin/vmservice/observ...
File runtime/bin/vmservice/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/773303003/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/service/object.dart:561: architecture
= map['targetCPU'];
On 2014/12/04 16:07:21, Cutch wrote:
> Why not rename 'architecture' to be targetCPU?

Done.

https://codereview.chromium.org/773303003/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/service/object.dart:562:
architectureBits = architecture.contains('64') ? 64 : 32;
On 2014/12/04 16:07:21, Cutch wrote:
> Can we ensure this will always be correct? Why not send over explicit info
from
> the VM?

Done.

https://codereview.chromium.org/773303003/diff/1/runtime/bin/vmservice/observ...
runtime/bin/vmservice/observatory/lib/src/service/object.dart:1443: @observable
int vmId;
On 2014/12/04 16:07:21, Cutch wrote:
> vmCid?

Done.

[Cutch, 2014-12-04 17:40:33]

lgtm after checking UI still functions.

https://codereview.chromium.org/773303003/diff/40001/runtime/bin/vmservice/ob...
File runtime/bin/vmservice/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/773303003/diff/40001/runtime/bin/vmservice/ob...
runtime/bin/vmservice/observatory/lib/src/service/object.dart:336: @observable
String targetCPU;
check that the VM view still works. It probably references the 'architecture'
string.

[koda, 2014-12-04 17:41:52]

https://codereview.chromium.org/773303003/diff/40001/runtime/bin/vmservice/ob...
File runtime/bin/vmservice/observatory/lib/src/service/object.dart (right):

https://codereview.chromium.org/773303003/diff/40001/runtime/bin/vmservice/ob...
runtime/bin/vmservice/observatory/lib/src/service/object.dart:336: @observable
String targetCPU;
On 2014/12/04 17:40:33, Cutch wrote:
> check that the VM view still works. It probably references the 'architecture'
> string.

No, this field was completely unused until now.

[koda, 2014-12-04 19:07:37]

Committed patchset #4 (id:60001) manually as r42115 (presubmit successful).