Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 773183002: Enable inlining inside try-blocks in the VM's optimizing compiler. (Closed)

Created:
6 years ago by Florian Schneider
Modified:
6 years ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Enable inlining inside try-blocks in the VM's optimizing compiler. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=42103

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -16 lines) Patch
M runtime/vm/flow_graph_builder.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/flow_graph_builder.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/flow_graph_inliner.cc View 1 2 chunks +11 lines, -9 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language.h View 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Florian Schneider
6 years ago (2014-12-03 12:47:14 UTC) #2
zerny-google
https://codereview.chromium.org/773183002/diff/1/runtime/vm/flow_graph_inliner.cc File runtime/vm/flow_graph_inliner.cc (right): https://codereview.chromium.org/773183002/diff/1/runtime/vm/flow_graph_inliner.cc#newcode726 runtime/vm/flow_graph_inliner.cc:726: intptr_t try_index = call_data->call->GetBlock()->try_index(); Nit: cache the GetBlock call.
6 years ago (2014-12-03 13:22:27 UTC) #4
Florian Schneider
https://codereview.chromium.org/773183002/diff/1/runtime/vm/flow_graph_inliner.cc File runtime/vm/flow_graph_inliner.cc (right): https://codereview.chromium.org/773183002/diff/1/runtime/vm/flow_graph_inliner.cc#newcode726 runtime/vm/flow_graph_inliner.cc:726: intptr_t try_index = call_data->call->GetBlock()->try_index(); On 2014/12/03 13:22:27, zerny-google wrote: ...
6 years ago (2014-12-03 13:45:43 UTC) #5
Vyacheslav Egorov (Google)
LGTM if we have tests covering this (especially with throws)
6 years ago (2014-12-03 20:28:25 UTC) #6
Florian Schneider
6 years ago (2014-12-04 12:29:35 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as r42103 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698