Issue 772133002: Evaluate annotations using ConstantValueComputer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 772133002: Evaluate annotations using ConstantValueComputer. (Closed)

Created:
6 years ago by Paul Berry

Modified:
6 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, Johnni Winther

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Evaluate annotations using ConstantValueComputer. This is a step towards fixing bug 15467 (Analyzer does not handle aliases of @proxy). It should also help integration between analyzer and dart2js (since Dart2js will need to know the constant values associated with annotations). R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=42076

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+299 lines, -3 lines)			Patch
M	pkg/analyzer/lib/src/generated/constant.dart	View	6 chunks	+66 lines, -3 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/element.dart	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/generated/all_the_rest_test.dart	View	4 chunks	+226 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

6 years ago (2014-12-02 20:59:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42076 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages