Add Isolate.current getter, returning the current isolate as an Isolate object.

Add Isolate.current getter, returning the current isolate as an Isolate object.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42499

[Lasse Reichstein Nielsen, 2014-12-02 10:46:37]

lrn@google.com changed reviewers:
+ floitsch@google.com, iposva@google.com

[Lasse Reichstein Nielsen, 2014-12-02 10:47:39]

https://codereview.chromium.org/771993003/diff/1/runtime/lib/isolate.cc
File runtime/lib/isolate.cc (right):

https://codereview.chromium.org/771993003/diff/1/runtime/lib/isolate.cc#newco...
runtime/lib/isolate.cc:259: Capability::New(isolate->terminate_capability())));
This doesn't seem to be working.
Ivan: Does the VM canonicalize capability objects when sent through SendPorts,
so it can get away with using identity as equality?
(If so, I need some canonicalization here)

[floitsch, 2014-12-02 12:13:57]

LGTM.

https://codereview.chromium.org/771993003/diff/1/runtime/lib/isolate_patch.dart
File runtime/lib/isolate_patch.dart (right):

https://codereview.chromium.org/771993003/diff/1/runtime/lib/isolate_patch.da...
runtime/lib/isolate_patch.dart:385: static List _getCurrent() native
"Isolate_getCurrent";
s/_getCurrent()/_getPortAndCapabilitiesOfCurrentIsolate()/
?

It's long, but only used once.

https://codereview.chromium.org/771993003/diff/1/sdk/lib/isolate/isolate.dart
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/771993003/diff/1/sdk/lib/isolate/isolate.dart...
sdk/lib/isolate/isolate.dart:125: * This isolate can be sent to other isolates
created using [Isolate.spawn]
a: we should agree on terminology for these kind of isolates (and the other
ones). "Local", "same-source", ...

b: I don't think we need to mention this restriction. It's implied by the normal
serialization rules.

c: maybe just add examples instead.

https://codereview.chromium.org/771993003/diff/1/sdk/lib/isolate/isolate.dart...
sdk/lib/isolate/isolate.dart:128: * It gives access to the capabilities needed
to inspect, pause or kill
New line before?

[Lasse Reichstein Nielsen, 2014-12-03 15:34:30]

https://codereview.chromium.org/771993003/diff/1/sdk/lib/isolate/isolate.dart
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/771993003/diff/1/sdk/lib/isolate/isolate.dart...
sdk/lib/isolate/isolate.dart:125: * This isolate can be sent to other isolates
created using [Isolate.spawn]
Removed. Can't think of a short example that isn't entirely contrived.

https://codereview.chromium.org/771993003/diff/1/sdk/lib/isolate/isolate.dart...
sdk/lib/isolate/isolate.dart:128: * It gives access to the capabilities needed
to inspect, pause or kill
Removed the previous paragraph.

https://codereview.chromium.org/771993003/diff/20001/runtime/lib/isolate.cc
File runtime/lib/isolate.cc (right):

https://codereview.chromium.org/771993003/diff/20001/runtime/lib/isolate.cc#n...
runtime/lib/isolate.cc:261: }
The problem with capabilities doesn't seem to originate here - other
capabilities also fail to be equal to copies of themselves.

I think Capability is inheriting equality from Object, and it isn't being
canonicalized when sent through sendports.
The test isolate/capability_test fails, and has likely never worked (it's still
marked as "Fails # not implemented" in the status file).

[Lasse Reichstein Nielsen, 2014-12-08 07:44:16]

With fix to Capability, this now works. PTAL.

[floitsch, 2014-12-08 09:16:00]

still LGTM.

[Lasse Reichstein Nielsen, 2014-12-09 07:14:35]

Ivan?

[Lasse Reichstein Nielsen, 2014-12-19 07:06:24]

Committed patchset #3 (id:40001) manually as 42499 (presubmit successful).