Issue 771673002: Add a test to test that substitutions are emitted for classes that are only used as type arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 771673002: Add a test to test that substitutions are emitted for classes that are only used as type arguments. (Closed)

Created:
6 years ago by karlklose

Modified:
6 years ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a test to test that substitutions are emitted for classes that are only used as type arguments. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=42059

Patch Set 2 : Address comment. #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
	A	tests/language/type_argument_substitution_test.dart	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

floitsch

https://codereview.chromium.org/771673002/diff/1/tests/language/type_argument_substitution_test.dart File tests/language/type_argument_substitution_test.dart (right): https://codereview.chromium.org/771673002/diff/1/tests/language/type_argument_substitution_test.dart#newcode20 tests/language/type_argument_substitution_test.dart:20: ? new X<B>() : 42; Make the right-hand side ...

6 years ago (2014-12-01 16:01:05 UTC) #3

karlklose

Committed patchset #2 (id:20001) manually as 42059 (presubmit successful).

6 years ago (2014-12-02 09:01:16 UTC) #4

karlklose

6 years ago (2014-12-02 09:01:33 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/771673002/diff/1/tests/language/type_argument...
File tests/language/type_argument_substitution_test.dart (right):

https://codereview.chromium.org/771673002/diff/1/tests/language/type_argument...
tests/language/type_argument_substitution_test.dart:20: ? new X<B>() : 42;
On 2014/12/01 16:01:05, floitsch wrote:
> Make the right-hand side something that could satisfy the is-check.
> Otherwise our type-propagator could constant fold the is-check away.

Done.

Expand Messages | Collapse Messages

Issue 771673002: Add a test to test that substitutions are emitted for classes that are only used as type arguments. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comment. #

Messages