Improve receiver narrowing in type propagation.

Improve receiver narrowing in type propagation.

BUG=
R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42162

[herhut, 2014-12-01 13:43:23]

Patchset #1 (id:1) has been deleted

[herhut, 2014-12-01 13:44:22]

herhut@google.com changed reviewers:
+ johnniwinther@google.com, karlklose@google.com

[Johnni Winther, 2014-12-08 11:43:18]

lgtm

https://codereview.chromium.org/771613002/diff/20001/pkg/compiler/lib/src/ssa...
File pkg/compiler/lib/src/ssa/types_propagation.dart (right):

https://codereview.chromium.org/771613002/diff/20001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/types_propagation.dart:323: bool _excludeNsm(Element
element) {
_excludeNsm -> _excludeNoSuchMethod

https://codereview.chromium.org/771613002/diff/20001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/types_propagation.dart:399: class _ClassSet {
Move this class to `world.dart`.

https://codereview.chromium.org/771613002/diff/20001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/types_propagation.dart:406:
_ClassSet.from(FunctionSetQuery query, this.world, Backend backend,
Remove unused `backend` parameter.

https://codereview.chromium.org/771613002/diff/20001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/types_propagation.dart:407: {filter: null}) :
`{filter: null}` -> `{bool filter(Element element)}`

and indent all parameters under `FunctionSetQuery ...`.

[herhut, 2014-12-08 13:40:17]

https://codereview.chromium.org/771613002/diff/20001/pkg/compiler/lib/src/ssa...
File pkg/compiler/lib/src/ssa/types_propagation.dart (right):

https://codereview.chromium.org/771613002/diff/20001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/types_propagation.dart:323: bool _excludeNsm(Element
element) {
On 2014/12/08 11:43:18, Johnni Winther wrote:
> _excludeNsm -> _excludeNoSuchMethod

Done.

https://codereview.chromium.org/771613002/diff/20001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/types_propagation.dart:399: class _ClassSet {
On 2014/12/08 11:43:18, Johnni Winther wrote:
> Move this class to `world.dart`.

Added a TODO.

https://codereview.chromium.org/771613002/diff/20001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/types_propagation.dart:406:
_ClassSet.from(FunctionSetQuery query, this.world, Backend backend,
On 2014/12/08 11:43:18, Johnni Winther wrote:
> Remove unused `backend` parameter.

Thanks! That was a left over from refactoring the interface.

Done.

https://codereview.chromium.org/771613002/diff/20001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/types_propagation.dart:407: {filter: null}) :
On 2014/12/08 11:43:18, Johnni Winther wrote:
> `{filter: null}` -> `{bool filter(Element element)}`
> 
> and indent all parameters under `FunctionSetQuery ...`.

Done.

[herhut, 2014-12-08 13:41:14]

Committed patchset #2 (id:40001) manually as 42162 (presubmit successful).

[sra1, 2014-12-09 04:08:17]

sra@google.com changed reviewers:
+ sra@google.com

[sra1, 2014-12-09 04:08:18]

TDC

https://codereview.chromium.org/771613002/diff/40001/pkg/compiler/lib/src/ssa...
File pkg/compiler/lib/src/ssa/types_propagation.dart (right):

https://codereview.chromium.org/771613002/diff/40001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/types_propagation.dart:442: return new
_ClassSet._internal(intersected, world);
Can we easily tell when to return 'this'?
It should happen often - i.e. when hitting the fixpoint.

https://codereview.chromium.org/771613002/diff/40001/pkg/compiler/lib/src/ssa...
pkg/compiler/lib/src/ssa/types_propagation.dart:451: return new
TypeMask.unionOf(classes.map(_toMask), world);
It would be useful, if 'this' is returned from 'intersect', to also cache the
mask on 'this'.

Does TypeMask.unionOf return the same representation regardless of the iteration
order of the Set classes?