Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 771253002: Add a flag to prohibit plurals/genders that don't take up the whole string. (Closed)

Created:
6 years ago by Alan Knight
Modified:
6 years ago
Reviewers:
tjblasi
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a flag to prohibit plurals/genders that don't take up the whole string. BUG= R=tjblasi@google.com Committed: https://code.google.com/p/dart/source/detail?r=42071

Patch Set 1 #

Patch Set 2 : Update pubspec and CHANGELOG #

Total comments: 2

Patch Set 3 : Review fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -28 lines) Patch
M pkg/intl/CHANGELOG.md View 1 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/intl/bin/extract_to_arb.dart View 1 chunk +10 lines, -4 lines 0 comments Download
M pkg/intl/bin/generate_from_arb.dart View 1 chunk +12 lines, -7 lines 0 comments Download
M pkg/intl/lib/extract_messages.dart View 7 chunks +28 lines, -6 lines 0 comments Download
M pkg/intl/pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
A pkg/intl/test/message_extraction/embedded_plural_text_after.dart View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A + pkg/intl/test/message_extraction/embedded_plural_text_after_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download
A pkg/intl/test/message_extraction/embedded_plural_text_before.dart View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
A + pkg/intl/test/message_extraction/embedded_plural_text_before_test.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/intl/test/message_extraction/failed_extraction_test.dart View 1 2 2 chunks +9 lines, -3 lines 0 comments Download
M pkg/intl/test/message_extraction/message_extraction_test.dart View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Alan Knight
Hi Tim, Mind reviewing an Intl change?
6 years ago (2014-12-02 19:09:10 UTC) #2
tjblasi
lgtm https://codereview.chromium.org/771253002/diff/20001/pkg/intl/test/message_extraction/embedded_plural_text_after.dart File pkg/intl/test/message_extraction/embedded_plural_text_after.dart (right): https://codereview.chromium.org/771253002/diff/20001/pkg/intl/test/message_extraction/embedded_plural_text_after.dart#newcode12 pkg/intl/test/message_extraction/embedded_plural_text_after.dart:12: zero: 'none', one: 'one', other: 'some')} plus some ...
6 years ago (2014-12-02 19:21:51 UTC) #3
Alan Knight
6 years ago (2014-12-02 20:18:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 42071 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698