Issue 770633003: tools: removed unused members, tiny cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 770633003: tools: removed unused members, tiny cleanup (Closed)

Created:
6 years ago by kevmoo

Modified:
6 years ago

Reviewers:
ricow1, Bill Hesse

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

tools: removed unused members, tiny cleanup R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=42106

Patch Set 2 : nits #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -28 lines)			Patch
M	tools/test.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/testing/dart/multitest.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/testing/dart/test_progress.dart	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/testing/dart/test_runner.dart	View		4 chunks	+0 lines, -5 lines	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1	9 chunks	+5 lines, -20 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ricow1

lgtm, thanks, small suggestion https://codereview.chromium.org/770633003/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/770633003/diff/1/tools/testing/dart/test_suite.dart#newcode778 tools/testing/dart/test_suite.dart:778: .forEach((FileSystemEntity fse) { .where((fse) => ...

6 years ago (2014-12-04 13:14:04 UTC) #3

kevmoo

6 years ago (2014-12-04 13:56:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 42106 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 770633003: tools: removed unused members, tiny cleanup (Closed)

Description

Patch Set 1 #

Patch Set 2 : nits #

Messages