First step to resolving simple API changes.

First step to resolving simple API changes.

Limitations:

1. Errors are not updated.

2. Classes are not resolved when it might be required.

3. Just method invocations, and just static elements.


R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=42153

[Brian Wilkerson, 2014-12-05 23:05:57]

LGTM, although there are a lot of missing doc comments that it would be nice if
you could add.

https://codereview.chromium.org/770333003/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/element.dart (right):

https://codereview.chromium.org/770333003/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/element.dart:3234: IntSet get users;
I'm concerned about keeping around unnecessary empty sets. It would be good to
measure to see what percentage of elements have empty sets and consider storing
'null' in place of empty sets if there would be a reasonable space savings from
doing so. (But not before this CL lands.)

https://codereview.chromium.org/770333003/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right):

https://codereview.chromium.org/770333003/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/incremental_resolver.dart:773: HashSet<Element>
_resolutionQueue = new HashSet<Element>();
I have some concerns about how long the incremental resolution task can take
once we go down this road. We have to be careful to keep the task durations
relatively short. It would be good to at least add a comment to remind us to
revisit this issue.

[scheglov, 2014-12-05 23:48:43]

Committed patchset #1 (id:1) manually as 42153 (presubmit successful).

[scheglov, 2014-12-05 23:49:05]

https://codereview.chromium.org/770333003/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/element.dart (right):

https://codereview.chromium.org/770333003/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/element.dart:3234: IntSet get users;
On 2014/12/05 23:05:57, Brian Wilkerson wrote:
> I'm concerned about keeping around unnecessary empty sets. It would be good to
> measure to see what percentage of elements have empty sets and consider
storing
> 'null' in place of empty sets if there would be a reasonable space savings
from
> doing so. (But not before this CL lands.)

Acknowledged.

https://codereview.chromium.org/770333003/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right):

https://codereview.chromium.org/770333003/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/incremental_resolver.dart:773: HashSet<Element>
_resolutionQueue = new HashSet<Element>();
On 2014/12/05 23:05:57, Brian Wilkerson wrote:
> I have some concerns about how long the incremental resolution task can take
> once we go down this road. We have to be careful to keep the task durations
> relatively short. It would be good to at least add a comment to remind us to
> revisit this issue.

Done.