Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(775)

Issue 77023004: Change InternetAddress back to abstract and make the constructor a factory (Closed)

Created:
7 years, 1 month ago by Søren Gjesse
Modified:
7 years, 1 month ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change InternetAddress back to abstract and make the constructor a factory This should make the InternetAddress a valid class again. TBR=ajohnsen@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=30467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M sdk/lib/_internal/lib/io_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/socket.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
7 years, 1 month ago (2013-11-20 13:23:33 UTC) #1
Søren Gjesse
Committed patchset #1 manually as r30467 (presubmit successful).
7 years, 1 month ago (2013-11-20 13:24:05 UTC) #2
Anders Johnsen
7 years, 1 month ago (2013-11-20 13:40:13 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698