Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 76963003: Fix crash evaluating metadata with super in a const constructor argument. (Closed)

Created:
7 years, 1 month ago by rmacnak
Modified:
7 years, 1 month ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Fix crash evaluating metadata with super in a const constructor argument. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=30491

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M runtime/vm/parser.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/lib/mirrors/metadata_constructor_arguments_test.dart View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmacnak
Thought of this when thinking about the prefixing dynamic bug...
7 years, 1 month ago (2013-11-20 01:07:38 UTC) #1
hausner
lgtm
7 years, 1 month ago (2013-11-20 04:45:58 UTC) #2
rmacnak
7 years, 1 month ago (2013-11-21 00:11:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30491 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698