Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 769533003: Mark empty HashMap constructor as NoThrows. (Closed)

Created:
6 years ago by herhut
Modified:
6 years ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mark empty HashMap constructor as NoThrows. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=42158

Patch Set 1 #

Patch Set 2 : added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -2 lines) Patch
M sdk/lib/_internal/compiler/js_lib/collection_patch.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A tests/compiler/dart2js/unused_empty_map_test.dart View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
herhut
6 years ago (2014-12-01 12:35:03 UTC) #1
karlklose
On 2014/12/01 12:35:03, herhut wrote: Could you add a test?
6 years ago (2014-12-01 13:17:00 UTC) #2
herhut
On 2014/12/01 13:17:00, karlklose wrote: > On 2014/12/01 12:35:03, herhut wrote: > > Could you ...
6 years ago (2014-12-01 14:36:50 UTC) #3
karlklose
LGTM.
6 years ago (2014-12-01 14:56:50 UTC) #4
herhut
6 years ago (2014-12-08 10:40:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42158 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698