Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 768233002: Extract DocumentationCommentToken with field. (Closed)

Created:
6 years ago by scheglov
Modified:
6 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Extract DocumentationCommentToken with field. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42056

Patch Set 1 #

Total comments: 2

Patch Set 2 : Keep only last multi-line or continuous single-line documentation comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -52 lines) Patch
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 2 chunks +19 lines, -27 lines 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 4 chunks +33 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 9 chunks +31 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
scheglov
6 years ago (2014-12-01 22:48:37 UTC) #1
Brian Wilkerson
LGTM once the parsing problem is fixed. https://codereview.chromium.org/768233002/diff/1/pkg/analyzer/lib/src/generated/parser.dart File pkg/analyzer/lib/src/generated/parser.dart (right): https://codereview.chromium.org/768233002/diff/1/pkg/analyzer/lib/src/generated/parser.dart#newcode6027 pkg/analyzer/lib/src/generated/parser.dart:6027: documentationTokens.add(commentToken); This ...
6 years ago (2014-12-01 23:08:43 UTC) #2
scheglov
PTAL https://codereview.chromium.org/768233002/diff/1/pkg/analyzer/lib/src/generated/parser.dart File pkg/analyzer/lib/src/generated/parser.dart (right): https://codereview.chromium.org/768233002/diff/1/pkg/analyzer/lib/src/generated/parser.dart#newcode6027 pkg/analyzer/lib/src/generated/parser.dart:6027: documentationTokens.add(commentToken); On 2014/12/01 23:08:43, Brian Wilkerson wrote: > ...
6 years ago (2014-12-01 23:27:53 UTC) #3
Brian Wilkerson
LGTM
6 years ago (2014-12-02 00:52:57 UTC) #4
scheglov
6 years ago (2014-12-02 01:39:30 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42056 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698