Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 767723002: Remove todo and add test progress status. (Closed)

Created:
6 years ago by ahe
Modified:
6 years ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, kasperl, lukechurch
Visibility:
Public.

Description

Remove todo and add test progress status. R=johnniwinther@google.com Committed: https://code.google.com/p/dart/source/detail?r=42244

Patch Set 1 #

Total comments: 1

Patch Set 2 : Merged with r42243. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M dart/tests/try/web/incremental_compilation_update_test.dart View 1 3 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ahe
https://codereview.chromium.org/767723002/diff/1/dart/tests/try/web/incremental_compilation_update_test.dart File dart/tests/try/web/incremental_compilation_update_test.dart (left): https://codereview.chromium.org/767723002/diff/1/dart/tests/try/web/incremental_compilation_update_test.dart#oldcode1305 dart/tests/try/web/incremental_compilation_update_test.dart:1305: // TODO(ahe): Use forEach(print) when closures are computed correctly. ...
6 years ago (2014-11-28 11:45:19 UTC) #2
Johnni Winther
lgtm
6 years ago (2014-12-09 11:57:35 UTC) #3
ahe
6 years ago (2014-12-10 14:21:29 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 42244 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698