A whitespace-only change can be incremental anywhere.

A whitespace-only change can be incremental anywhere.

Just one change thought.
Does not work for a formatting causing multiple whitespace changes.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=42012

[Brian Wilkerson, 2014-11-26 23:22:38]

LGTM

https://codereview.chromium.org/767453002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right):

https://codereview.chromium.org/767453002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/incremental_resolver.dart:929: // check for a
whitespace only change
Does this handle changes in dartdoc comments? Changes in dartdoc comments should
not be considered to be whitespace changes because they do get resolved.

/** [A] */
class A {}
class B {}

becomes:

/** [A] and [B] */
class A {}
class B {}

[scheglov, 2014-11-26 23:25:37]

https://codereview.chromium.org/767453002/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/incremental_resolver.dart (right):

https://codereview.chromium.org/767453002/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/incremental_resolver.dart:929: // check for a
whitespace only change
On 2014/11/26 23:22:37, Brian Wilkerson wrote:
> Does this handle changes in dartdoc comments? Changes in dartdoc comments
should
> not be considered to be whitespace changes because they do get resolved.
> 
> /** [A] */
> class A {}
> class B {}
> 
> becomes:
> 
> /** [A] and [B] */
> class A {}
> class B {}

Not yet.
Support for incremental resolving dartdoc comments will follow.

[scheglov, 2014-11-26 23:26:26]

Committed patchset #1 (id:1) manually as 42012 (presubmit successful).