Issue 766723002: Add an optional decorator to SExprStringifier to augment the output of nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 766723002: Add an optional decorator to SExprStringifier to augment the output of nodes. (Closed)

Created:
6 years ago by karlklose

Modified:
6 years ago

Reviewers:
sigurdm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add an optional decorator to SExprStringifier to augment the output of nodes. R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=42018

Patch Set 2 : Address comment. #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -0 lines)			Patch
	M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart	View	1	2 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sigurdm

lgtm https://codereview.chromium.org/766723002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart File pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart (right): https://codereview.chromium.org/766723002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart#newcode34 pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart:34: return (decorator != null) ? decorator(node, s) : ...

6 years ago (2014-11-27 12:53:37 UTC) #2

karlklose

Committed patchset #2 (id:20001) manually as 42018 (presubmit successful).

6 years ago (2014-11-27 13:24:22 UTC) #3

karlklose

6 years ago (2014-11-27 13:25:14 UTC) #4

Message was sent while issue was closed.

Thanks, Sigurd!

https://codereview.chromium.org/766723002/diff/1/pkg/compiler/lib/src/cps_ir/...
File pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart (right):

https://codereview.chromium.org/766723002/diff/1/pkg/compiler/lib/src/cps_ir/...
pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart:34: return (decorator !=
null) ? decorator(node, s) : s;
On 2014/11/27 12:53:37, sigurdm wrote:
> One fewer negations:
> 
> return decorator == null ? s : decorator(node, s);

Done.

Expand Messages | Collapse Messages

Issue 766723002: Add an optional decorator to SExprStringifier to augment the output of nodes. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comment. #

Messages