Add a [prints] matcher to the matcher library.

Add a [prints] matcher to the matcher library.

R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42270

[nweiz, 2014-12-05 02:42:26]

nweiz@google.com changed reviewers:
+ rnystrom@google.com

[Bob Nystrom, 2014-12-05 18:14:54]

What's the motivation for this?

https://codereview.chromium.org/766653005/diff/1/pkg/matcher/lib/src/prints_m...
File pkg/matcher/lib/src/prints_matcher.dart (right):

https://codereview.chromium.org/766653005/diff/1/pkg/matcher/lib/src/prints_m...
pkg/matcher/lib/src/prints_matcher.dart:20: /// the function (using [Zone]
scoping) until that Future completes will be
"will be" -> "is".

https://codereview.chromium.org/766653005/diff/1/pkg/matcher/lib/src/prints_m...
pkg/matcher/lib/src/prints_matcher.dart:23: /// This only tracks text printed
using the [print] function.
This means going between print(), stdout.write(), and/or console.write() can
break testable behavior. :(

https://codereview.chromium.org/766653005/diff/1/pkg/matcher/test/prints_matc...
File pkg/matcher/test/prints_matcher_test.dart (right):

https://codereview.chromium.org/766653005/diff/1/pkg/matcher/test/prints_matc...
pkg/matcher/test/prints_matcher_test.dart:26: }, prints("Hello\nWorld!\n"));
Are the line endings the same on Windows?

[nweiz, 2014-12-09 01:01:01]

> What's the motivation for this?

In general, library code that has some default behavior of printing to the
console that needs to be tested. In particular, I'm working on a command
dispatcher for args, and I want to test it printing help information.

https://codereview.chromium.org/766653005/diff/1/pkg/matcher/lib/src/prints_m...
File pkg/matcher/lib/src/prints_matcher.dart (right):

https://codereview.chromium.org/766653005/diff/1/pkg/matcher/lib/src/prints_m...
pkg/matcher/lib/src/prints_matcher.dart:20: /// the function (using [Zone]
scoping) until that Future completes will be
On 2014/12/05 18:14:53, Bob Nystrom wrote:
> "will be" -> "is".

Done.

https://codereview.chromium.org/766653005/diff/1/pkg/matcher/lib/src/prints_m...
pkg/matcher/lib/src/prints_matcher.dart:23: /// This only tracks text printed
using the [print] function.
On 2014/12/05 18:14:53, Bob Nystrom wrote:
> This means going between print(), stdout.write(), and/or console.write() can
> break testable behavior. :(

That's already true; anyone could be using a custom Zone.

https://codereview.chromium.org/766653005/diff/1/pkg/matcher/test/prints_matc...
File pkg/matcher/test/prints_matcher_test.dart (right):

https://codereview.chromium.org/766653005/diff/1/pkg/matcher/test/prints_matc...
pkg/matcher/test/prints_matcher_test.dart:26: }, prints("Hello\nWorld!\n"));
On 2014/12/05 18:14:53, Bob Nystrom wrote:
> Are the line endings the same on Windows?

I think so. I figure it's easier to test on the bots than it is for you to boot
up your Windows machine and test manually.

[nweiz, 2014-12-09 01:02:37]

Code review changes

[Sean Eagan, 2014-12-09 16:17:57]

On 2014/12/09 01:01:01, nweiz wrote:
> I'm working on a command
> dispatcher for args, and I want to test it printing help information.

I have a "dispatcher for args" here:

  https://github.com/seaneagan/unscripted

Would you be interested in collaborating?  If you have a different interface in
mind, I'd love to hear what it is, so I can consider whether it is a better than
unscripted's.

Thanks!

[nweiz, 2014-12-10 00:18:43]

On 2014/12/09 16:17:57, Sean Eagan wrote:
> On 2014/12/09 01:01:01, nweiz wrote:
> > I'm working on a command
> > dispatcher for args, and I want to test it printing help information.
> 
> I have a "dispatcher for args" here:
> 
>   https://github.com/seaneagan/unscripted
> 
> Would you be interested in collaborating?  If you have a different interface
in
> mind, I'd love to hear what it is, so I can consider whether it is a better
than
> unscripted's.
> 
> Thanks!

I meant "args" as in the package of that name:
https://pub.dartlang.org/packages/args. unscripted looks like a cool take on the
idea, but I think the API is going in a different direction than what I'm
working on; I'm doing a more inheritance-based model with tight integration with
the existing args API.

I'll have a CL out for it soon, and I'll cc you on it so you can take a look.

[Sean Eagan, 2014-12-10 22:17:58]

On 2014/12/10 00:18:43, nweiz wrote:
> On 2014/12/09 16:17:57, Sean Eagan wrote:
> > On 2014/12/09 01:01:01, nweiz wrote:
> > > I'm working on a command
> > > dispatcher for args, and I want to test it printing help information.
> > 
> > I have a "dispatcher for args" here:
> > 
> >   https://github.com/seaneagan/unscripted
> > 
> > Would you be interested in collaborating?  If you have a different interface
> in
> > mind, I'd love to hear what it is, so I can consider whether it is a better
> than
> > unscripted's.
> > 
> > Thanks!
> 
> I meant "args" as in the package of that name:
> https://pub.dartlang.org/packages/args. unscripted looks like a cool take on
the
> idea, but I think the API is going in a different direction than what I'm
> working on; I'm doing a more inheritance-based model with tight integration
with
> the existing args API.
> 
> I'll have a CL out for it soon, and I'll cc you on it so you can take a look.

Thanks!

[Bob Nystrom, 2014-12-10 22:33:16]

lgtm

https://codereview.chromium.org/766653005/diff/20001/pkg/matcher/CHANGELOG.md
File pkg/matcher/CHANGELOG.md (right):

https://codereview.chromium.org/766653005/diff/20001/pkg/matcher/CHANGELOG.md...
pkg/matcher/CHANGELOG.md:3: * Add a `prints` matcher that
that...

[nweiz, 2014-12-10 22:46:48]

Code review changes

[nweiz, 2014-12-10 22:51:40]

Committed patchset #3 (id:40001) manually as 42270 (presubmit successful).

[nweiz, 2014-12-10 23:16:47]

https://codereview.chromium.org/766653005/diff/20001/pkg/matcher/CHANGELOG.md
File pkg/matcher/CHANGELOG.md (right):

https://codereview.chromium.org/766653005/diff/20001/pkg/matcher/CHANGELOG.md...
pkg/matcher/CHANGELOG.md:3: * Add a `prints` matcher that
On 2014/12/10 22:33:15, Bob Nystrom wrote:
> that...

Done.