Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Issue 76653004: Remove an invalid assert in converting a dart.core.Stacktrace to a debugger stacktrace. (Closed)

Created:
7 years, 1 month ago by rmacnak
Modified:
7 years, 1 month ago
Reviewers:
siva, hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Remove an invalid assert in converting a dart.core.Stacktrace to a debugger stacktrace. Fixes an Aw, Snap when trying to debug an OutOfMemory error on debug builds of Dartium. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=30433

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M runtime/vm/debugger.cc View 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
rmacnak
7 years, 1 month ago (2013-11-19 22:08:00 UTC) #1
siva
lgtm
7 years, 1 month ago (2013-11-20 01:00:30 UTC) #2
rmacnak
7 years, 1 month ago (2013-11-20 01:21:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30433 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698