Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 766393002: Fix a couple bugs in r42055. (Closed)

Created:
6 years ago by nweiz
Modified:
6 years ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix a couple bugs in r42055. This works around https://github.com/dart-lang/async_await/issues/72, fixes an incorrect variable name, and updates the async-compiled output. R=rnystrom@google.com TBR Committed: https://code.google.com/p/dart/source/detail?r=42057

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -66 lines) Patch
M sdk/lib/_internal/pub/lib/src/io.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/source/hosted.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub_generated/bin/async_compile.dart View 5 chunks +10 lines, -9 lines 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/io.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/source/hosted.dart View 1 chunk +53 lines, -51 lines 0 comments Download
M sdk/lib/_internal/pub_generated/test/cache/repair/handles_corrupted_global_lockfile_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub_generated/test/cache/repair/recompiles_snapshots_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years ago (2014-12-02 01:52:34 UTC) #1
nweiz
Committed patchset #1 (id:1) manually as 42057 (presubmit successful).
6 years ago (2014-12-02 01:52:49 UTC) #2
Bob Nystrom
6 years ago (2014-12-02 19:17:19 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698