Issue 764633002: Remove eager assertion from UnboxedIntConverterInstr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 764633002: Remove eager assertion from UnboxedIntConverterInstr. (Closed)

Created:
6 years ago by Vyacheslav Egorov (Google)

Modified:
6 years ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove eager assertion from UnboxedIntConverterInstr. When inserting a mint->int32 convertion for a phi operand we will not pass correct deopt_id into the UnboxedIntConverter constructor but will instead force copy deoptimization target via CopyDeoptTarget at the end of the InsertConversion. BUG=http://dartbug.com/21728 R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=42011

Patch Set 1 #

Created: 6 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	runtime/vm/intermediate_language.h	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Vyacheslav Egorov (Google)

6 years ago (2014-11-26 22:50:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 42011 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages