Issue 764243003: Updated detached tokens of references in documentation comments.

Issue 764243003: Updated detached tokens of references in documentation comments. (Closed)

Created:
6 years ago by scheglov

Modified:
6 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Updated detached tokens of references in documentation comments. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=42050

Patch Set 1 #

Total comments: 2

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+123 lines, -55 lines)			Patch
M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View	4 chunks	+28 lines, -13 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/parser.dart	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/scanner.dart	View	2 chunks	+8 lines, -1 line	2 comments	Download
M	pkg/analyzer/test/generated/incremental_resolver_test.dart	View	3 chunks	+38 lines, -10 lines	0 comments	Download
M	pkg/analyzer/test/generated/parser_test.dart	View	8 chunks	+44 lines, -27 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/764243003/diff/1/pkg/analyzer/lib/src/generated/scanner.dart File pkg/analyzer/lib/src/generated/scanner.dart (right): https://codereview.chromium.org/764243003/diff/1/pkg/analyzer/lib/src/generated/scanner.dart#newcode246 pkg/analyzer/lib/src/generated/scanner.dart:246: final List<Token> references = <Token>[]; How hard would ...

6 years ago (2014-12-01 19:41:19 UTC) #2

scheglov

Committed patchset #1 (id:1) manually as 42050 (presubmit successful).

6 years ago (2014-12-01 22:23:05 UTC) #3

scheglov

6 years ago (2014-12-01 22:49:22 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/764243003/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/scanner.dart (right):

https://codereview.chromium.org/764243003/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/scanner.dart:246: final List<Token> references =
<Token>[];
On 2014/12/01 19:41:19, Brian Wilkerson wrote:
> How hard would it be to have a subclass of CommentToken named something like
> DocumentationCommentToken that had a actual field for 'references' and a
getter
> in CommentToken that returned an unmodifiable empty list of tokens? It would
be
> nice to not have the extra objects taking up space when we don't need them.

https://codereview.chromium.org/768233002

Expand Messages | Collapse Messages