Issue 76423004: De-mangle private identifiers returned by the debugger API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 76423004: De-mangle private identifiers returned by the debugger API. (Closed)

Created:
7 years, 1 month ago by rmacnak

Modified:
7 years, 1 month ago

Reviewers:
siva, hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

De-mangle private identifiers returned by the debugger API. BUG=http://dartbug.com/14892 R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=30436

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	runtime/vm/debugger.cc	View		3 chunks	+3 lines, -0 lines	0 comments	Download
	M	runtime/vm/debugger_api_impl.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rmacnak

Committed patchset #1 manually as r30436 (presubmit successful).

7 years, 1 month ago (2013-11-20 01:40:23 UTC) #3

hausner

7 years, 1 month ago (2013-11-20 04:56:58 UTC) #4

Message was sent while issue was closed.

I don't think this change is OK. An instance may have fields with the same
private name X but introduced in different libraries. If you chop off the
library mangling bit, the debug client can no longer determine where the fields
are from.

We can discuss tomorrow in the office, but we've had this discussion with the
Dartium and Editor folks in the past and came to the conclusion that the client
must unmangle the names.

Expand Messages | Collapse Messages