Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 764113005: dart2js: Always generate functions for rti substitutions. (Closed)

Created:
6 years ago by floitsch
Modified:
6 years ago
Reviewers:
karlklose, zarah
CC:
reviews_dartlang.org, sra1
Visibility:
Public.

Description

dart2js: Always generate functions for rti substitutions. R=karlklose@google.com, zarah@google.com Committed: https://code.google.com/p/dart/source/detail?r=42062

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -16 lines) Patch
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 4 chunks +5 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M sdk/lib/_internal/compiler/js_lib/js_rti.dart View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
6 years ago (2014-12-01 16:09:26 UTC) #2
karlklose
LGTM.
6 years ago (2014-12-01 18:31:37 UTC) #3
zarah
LGTM
6 years ago (2014-12-02 09:38:50 UTC) #4
floitsch
6 years ago (2014-12-02 12:18:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 42062 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698